Skip to content

fix datetime null error #6627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2023
Merged

fix datetime null error #6627

merged 3 commits into from
May 5, 2023

Conversation

LittleLittleCloud
Copy link
Member

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

fix #6626

@michaelgsharp
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #6627 (81752bd) into main (c0220f7) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6627      +/-   ##
==========================================
+ Coverage   68.38%   68.56%   +0.17%     
==========================================
  Files        1176     1200      +24     
  Lines      248210   250350    +2140     
  Branches    25915    26096     +181     
==========================================
+ Hits       169743   171648    +1905     
- Misses      71689    71895     +206     
- Partials     6778     6807      +29
Flag Coverage Δ
Debug 68.56% <100.00%> (+0.17%) ⬆️
production 63.03% <100.00%> (+0.27%) ⬆️
test 88.84% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Data/DataLoadSave/Database/DatabaseLoaderCursor.cs 24.33% <100.00%> (+1.25%) ⬆️
test/Microsoft.ML.Tests/DatabaseLoaderTests.cs 94.24% <100.00%> (+0.90%) ⬆️

... and 61 files with indirect coverage changes

@LittleLittleCloud LittleLittleCloud merged commit b567c37 into dotnet:main May 5, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@michaelgsharp michaelgsharp michaelgsharp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LittleLittleCloud LittleLittleCloud

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Can't load Datetime column when it contains null value

2 participants

@LittleLittleCloud @michaelgsharp